Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Repo] Revert OpenTelemetry.Instrumentation.AspNet OpenTelemetry.proj change #3811

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

CodeBlanch
Copy link
Member

It looks like #2069 added a rule for OpenTelemetry.Instrumentation.AspNet (which was moved to contrib a while back) to OpenTelemetry.proj. Reverting that bit.

@CodeBlanch CodeBlanch requested a review from a team October 24, 2022 21:04
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #3811 (38a7962) into main (6ce883b) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3811      +/-   ##
==========================================
+ Coverage   87.40%   87.44%   +0.04%     
==========================================
  Files         280      280              
  Lines       10755    10755              
==========================================
+ Hits         9400     9405       +5     
+ Misses       1355     1350       -5     
Impacted Files Coverage Δ
...tpListener/Internal/PrometheusCollectionManager.cs 73.62% <0.00%> (-2.20%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 96.21% <0.00%> (+1.08%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+2.94%) ⬆️
...tation/OpenTelemetryProtocolExporterEventSource.cs 95.00% <0.00%> (+10.00%) ⬆️
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 86.36% <0.00%> (+13.63%) ⬆️

@alanwest alanwest merged commit c5cb95e into open-telemetry:main Oct 24, 2022
@CodeBlanch CodeBlanch deleted the proj-cleanup branch October 24, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants